RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v3]

Doug Lea dl at openjdk.org
Wed Nov 22 11:27:08 UTC 2023


On Tue, 21 Nov 2023 21:27:08 GMT, Viktor Klang <vklang at openjdk.org> wrote:

>> Doug Lea has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into JDK-8319662
>>  - tweak cascades; reinstate an @Contended; resolve JDK-8319498
>>  - Support cascading idle timeouts
>
> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 3116:
> 
>> 3114:         } catch (Exception ex) {
>> 3115:             throw new RuntimeException(ex);
>> 3116:         }
> 
> Suggestion:
> 
>         try {
>             return task.join();
>         } catch (RuntimeException | Error unchecked) {
>             throw unchecked;
>         } catch (Exception checked) {
>             throw new RuntimeException(checked);
>         }

Thanks. Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16725#discussion_r1401902341


More information about the core-libs-dev mailing list