RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v10]

Severin Gehwolf sgehwolf at openjdk.org
Thu Nov 30 10:00:14 UTC 2023


On Wed, 29 Nov 2023 22:26:37 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Tighten ModifiedFilesExitTest
>>   
>>   Ensure the error message is reasonable and doesn't include
>>   Exceptions presented to the user.
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java line 621:
> 
>> 619:         String resName = String.format(OTHER_RESOURCES_FILE, modName);
>> 620:         try {
>> 621:             InputStream inStream = jdkJlink.getResourceAsStream(resName);
> 
> should it always create the resouorce file for each module even it's empty that might make it easier to catch any issue?

Sure this can be done. Makes the jimage a bit larger, but probably negligible as the total set of modules is usually small.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1410430626


More information about the core-libs-dev mailing list