RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v10]
Mandy Chung
mchung at openjdk.org
Thu Nov 30 17:22:16 UTC 2023
On Thu, 30 Nov 2023 09:57:33 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java line 621:
>>
>>> 619: String resName = String.format(OTHER_RESOURCES_FILE, modName);
>>> 620: try {
>>> 621: InputStream inStream = jdkJlink.getResourceAsStream(resName);
>>
>> should it always create the resouorce file for each module even it's empty that might make it easier to catch any issue?
>
> Sure this can be done. Makes the jimage a bit larger, but probably negligible as the total set of modules is usually small.
It adds more empty files which I expect should be very small increase in size. Since this is added by default, we can measure the difference and confirm.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1411000019
More information about the core-libs-dev
mailing list