RFR: 8317515: Unify the code of the parse*() families of methods in j.l.Integer and j.l.Long [v2]
温绍锦
duke at openjdk.org
Fri Oct 6 11:17:47 UTC 2023
On Thu, 5 Oct 2023 10:31:31 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:
>> See the [JBS issue](https://bugs.openjdk.org/browse/JDK-8317515) for the details.
>
> Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:
>
> Avoid localized integers in radix-out-of-range exception messages.
The reason parseUnsignedInt(CharSequence s, int beginIndex, int endIndex, int radix) cannot be inlined is because codeSize 350 is greater than default FreqInlineSize 325. Refactoring the exception handling code can be smaller than 325 without using @ForceInline.
Refactoring the code related to exception handling can make the code smaller and easier to be inlined. The code for constructing exceptions in these methods is encapsulated into methods and can be easily maintained together.
https://github.com/rgiulietti/jdk/pull/1
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16050#issuecomment-1750369837
PR Comment: https://git.openjdk.org/jdk/pull/16050#issuecomment-1750391108
More information about the core-libs-dev
mailing list