RFR: 8317515: Unify the code of the parse*() families of methods in j.l.Integer and j.l.Long [v2]
Quan Anh Mai
qamai at openjdk.org
Fri Oct 6 11:17:48 UTC 2023
On Fri, 6 Oct 2023 10:28:31 GMT, 温绍锦 <duke at openjdk.org> wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Avoid localized integers in radix-out-of-range exception messages.
>
> The reason parseUnsignedInt(CharSequence s, int beginIndex, int endIndex, int radix) cannot be inlined is because codeSize 350 is greater than default FreqInlineSize 325. Refactoring the exception handling code can be smaller than 325 without using @ForceInline.
@wenshao There are a lot of factors affecting the inlineability of a method and it is not advisable to rely on a method being inlined apart from really simple ones or those that are marked with `@ForceInline`.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16050#issuecomment-1750379747
More information about the core-libs-dev
mailing list