RFR: 8316996: Catalog API Enhancement: add a factory method [v2]

Joe Wang joehw at openjdk.org
Fri Oct 6 19:39:06 UTC 2023


On Fri, 6 Oct 2023 19:35:57 GMT, Joe Wang <joehw at openjdk.org> wrote:

>> Add a new factory method so that a CatalogResolver can be created with a resolve property on top of the Catalog object.
>
> Joe Wang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   addressing review comments, plus use URL for relative URI

Thanks Naoto. Addressing review comments. As we discussed offline, as we got CSR approval, we'll keep the javadoc in @param as a style choice. Added NPE for catalog; Fixed the redundant "returns"; Added error report. 
Furthermore, after consulting with Daniel, modified the Util method with URL instead of URI/Path as the former is a more straight-forward solution requiring no additional manipulation.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16045#issuecomment-1751316026


More information about the core-libs-dev mailing list