RFR: 8316996: Catalog API Enhancement: add a factory method [v2]

Naoto Sato naoto at openjdk.org
Fri Oct 6 20:58:07 UTC 2023


On Fri, 6 Oct 2023 19:35:57 GMT, Joe Wang <joehw at openjdk.org> wrote:

>> Add a new factory method so that a CatalogResolver can be created with a resolve property on top of the Catalog object.
>
> Joe Wang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   addressing review comments, plus use URL for relative URI

test/jaxp/javax/xml/jaxp/unittest/catalog/CatalogTest.java line 509:

> 507:     @Test(expectedExceptions = NullPointerException.class)
> 508:     public void testFeatureNull() {
> 509:         CatalogResolver resolver = CatalogManager.catalogResolver((CatalogFeatures)null, (URI)null);

I misunderstood this change, as I thought this was for testing `null` for the *new* method. Should we have the equivalent one for the new method?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16045#discussion_r1349313557


More information about the core-libs-dev mailing list