RFR: 8313621: test/jdk/jdk/internal/math/FloatingDecimal/TestFloatingDecimal should use RandomFactory [v2]

Brian Burkhalter bpb at openjdk.org
Wed Oct 11 18:25:25 UTC 2023


On Wed, 11 Oct 2023 15:45:29 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Change test to use `RandomFactory` instead of `new Random()` and convert it to JUnit 5.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8313621: assertTrue -> assertEquals

I should note that it is intentional to retain the looping inside the vlarious `@Test` methods. The test runs through 2_400_000 values generated by `Random` so I would expect that supplying the values by a `@MethodSource` or some such would generate a mammoth amount of output.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16130#issuecomment-1758255079


More information about the core-libs-dev mailing list