RFR: 8313621: test/jdk/jdk/internal/math/FloatingDecimal/TestFloatingDecimal should use RandomFactory [v2]
Raffaello Giulietti
rgiulietti at openjdk.org
Mon Oct 30 14:01:38 UTC 2023
On Wed, 11 Oct 2023 15:45:29 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> Change test to use `RandomFactory` instead of `new Random()` and convert it to JUnit 5.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>
> 8313621: assertTrue -> assertEquals
test/jdk/jdk/internal/math/FloatingDecimal/TestFloatingDecimal.java line 65:
> 63: /**
> 64: * @test
> 65: * @bug 7032154
Suggestion:
* @bug 7032154 8313621
test/jdk/jdk/internal/math/FloatingDecimal/TestFloatingDecimal.java line 78:
> 76: */
> 77: public class TestFloatingDecimal {
> 78: private static final int NUM_RANDOM_TESTS = 100000;
Suggestion:
private static final int NUM_RANDOM_TESTS = 100_000;
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16130#discussion_r1376266315
PR Review Comment: https://git.openjdk.org/jdk/pull/16130#discussion_r1376266653
More information about the core-libs-dev
mailing list