RFR: 8318124: JFR: Rewrite instrumentation to use Class-File API [v2]

[Erik Gahlin]

On Mon, 16 Oct 2023 06:01:01 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updates
>
> src/jdk.jfr/share/classes/jdk/jfr/internal/EventInstrumentation.java line 256:
> 
>> 254:                                 if (mtd.parameterList().size() == 1) {
>> 255:                                     ClassDesc type = mtd.parameterList().getFirst();
>> 256:                                     if (type.isClassOrInterface()) {
> 
> In the original, ASM-based code, there was no such check to ensure the type is non-primitive or non-array. Is this intended?

Yes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16195#discussion_r1360155805