RFR: 8318124: JFR: Rewrite instrumentation to use Class-File API [v2]

[Andrey Turbanov]

On Mon, 16 Oct 2023 05:07:42 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Hi,
>> 
>> Could I have a review of an enhancement that replaces the use of ASM with the new Class-File API. This change only deals with bytecode that writes event data into buffers. Bytecode transformations carried out by classes in jdk.jfr.internal.intrument package are kept as is. Plan is to try to replace those with events in java.base.
>> 
>> To simplify the review process, I have tried to keep the code in the classes EventInstrumentation and EventClassBuilder similar to what existed before. Further refactorizations may happen at a later stage. 
>> 
>> Testing: tier1-3 + jdk/jdk/jfr
>> 
>> Thanks
>> Erik
>
> Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updates

src/jdk.jfr/share/classes/jdk/jfr/internal/util/Bytecode.java line 45:

> 43: public final class Bytecode {
> 44: 
> 45:     private final static ClassDesc CD_Thread = classDesc(Thread.class);

Use blessed modifiers order
Suggestion:

    private static final ClassDesc CD_Thread = classDesc(Thread.class);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16195#discussion_r1360166922