RFR: JDK-8077371: Binary files in JAXP test should be removed [v11]

Roger Riggs rriggs at openjdk.org
Wed Oct 18 14:58:04 UTC 2023


On Sun, 15 Oct 2023 16:36:33 GMT, Mahendra Chhipa <mchhipa at openjdk.org> wrote:

>> Test is updated to create the binary files during test execution.
>
> Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Corrected use of whitespace in text block.

Please re-generate the files for each old revisions using the new template (and compare).
The "mechanically generated" notation is not in the versions in the PR.

test/jdk/javax/xml/jaxp/datatype/8033980/GregorianCalAndDurSerDataUtil.java line 127:

> 125:         HexFormat hex = HexFormat.of().withPrefix(" (byte) 0x").withSuffix(",");
> 126:         for (int i = 0; i < bytes.length; i += linelen) {
> 127:             sb.append("\n");

Add some indentation before each line so the resulting code is properly indented.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13537#issuecomment-1768642461
PR Review Comment: https://git.openjdk.org/jdk/pull/13537#discussion_r1364030623


More information about the core-libs-dev mailing list