RFR: JDK-8077371: Binary files in JAXP test should be removed [v11]

Mahendra Chhipa mchhipa at openjdk.org
Thu Oct 19 12:02:46 UTC 2023


On Wed, 18 Oct 2023 14:55:13 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Corrected use of whitespace in text block.
>
> test/jdk/javax/xml/jaxp/datatype/8033980/GregorianCalAndDurSerDataUtil.java line 127:
> 
>> 125:         HexFormat hex = HexFormat.of().withPrefix(" (byte) 0x").withSuffix(",");
>> 126:         for (int i = 0; i < bytes.length; i += linelen) {
>> 127:             sb.append("\n");
> 
> Add some indentation before each line so the resulting code is properly indented.

Added the indentation, reverted back to the use of Formatter class instead of HexFormat class.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13537#discussion_r1365396006


More information about the core-libs-dev mailing list