RFR: 8315578: PPC builds are broken after JDK-8304913 [v2]
Aleksey Shipilev
shade at openjdk.org
Thu Sep 7 16:21:19 UTC 2023
On Thu, 7 Sep 2023 13:51:31 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Similar to other issues in the same area. I have no PPC32 machine to test the build on, but this matches other fixes for other architectures (https://github.com/openjdk/jdk/commit/83c096d6e20cd6e1164bc666df1be197a10431eb) after this fix the PPC32 Zero build completes fine.
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - Switch to PPC32
> - Merge branch 'master' into JDK-8315578-ppc-builds
> - Fix
Yeah, so as I see from GHA testing:
STARTED ArchTest::checkParams '[8] ppc, PPC32, 32, BIG_ENDIAN, false'
java.lang.IllegalArgumentException: No enum constant jdk.internal.util.Architecture.PPC
at java.base/java.lang.Enum.valueOf(Enum.java:293)
at java.base/jdk.internal.util.Architecture.valueOf(Architecture.java:39)
at java.base/jdk.internal.util.Architecture.lookupByName(Architecture.java:99)
at ArchTest.checkParams(ArchTest.java:120)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
The test would verify that enum names are consistent with `os.arch`. Which would be `ppc`, based on build system pick. Therefore, we cannot do PPC32. I reverted the previous commit...
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15556#issuecomment-1710435235
More information about the core-libs-dev
mailing list