RFR: 8315578: PPC builds are broken after JDK-8304913 [v2]

Aleksey Shipilev shade at openjdk.org
Fri Sep 8 08:27:43 UTC 2023


On Thu, 7 Sep 2023 14:07:05 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Switch to PPC32
>>  - Merge branch 'master' into JDK-8315578-ppc-builds
>>  - Fix
>
> src/java.base/share/classes/jdk/internal/util/PlatformProps.java.template line 62:
> 
>> 60:     static final boolean TARGET_ARCH_IS_LOONGARCH64 = "@@OPENJDK_TARGET_CPU@@" == "loongarch64";
>> 61:     static final boolean TARGET_ARCH_IS_S390    = "@@OPENJDK_TARGET_CPU@@" == "s390";
>> 62:     static final boolean TARGET_ARCH_IS_PPC32   = "@@OPENJDK_TARGET_CPU@@" == "ppc";
> 
> The list is getting longer.  I'd suggest/request that all the enums be resorted alphabetically.  (now or later).

Agreed, @RogerRiggs? If so, please approve. 

Aside, I am planning to bring the stack of relevant backports to 21u, to unbreak it there.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15556#discussion_r1319536764


More information about the core-libs-dev mailing list