RFR: 8314891: Additional Zip64 extra header validation

[Sergey Bylokhov]

On Sat, 9 Sep 2023 14:33:53 GMT, Lance Andersen <lancea at openjdk.org> wrote:

> Please review this PR which improves the Zip64 extra header validation:
> 
> - Throw a ZipException If the extra len field is 0 and :
> -- size, csize, or loc offset are set to 0xFFFFFFFF
> -- disk starting number is set to 0xFFFF
> 
> - We have a valid size for the Zip64 extra header but we are missing the csize or loc fields if they are expected to be part of the header
> 
> Mach5 tiers 1-3 are clean

test/jdk/java/util/zip/ZipFile/MissingZIP64EntriesTest.java line 52:

> 50:  * starting number is set to 0xFFFF or when we have a valid Zip64 Extra header
> 51:  * size but missing the corresponding field.
> 52:  * @run junit MissingZIP64EntriesTest

Is this comment accurate? I think we should check 3 cases when the header extra len == 0, len == 8 and len ==16, but still do not contain all required information.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15650#discussion_r1322185302