RFR: 8314891: Additional Zip64 extra header validation [v2]

Lance Andersen lancea at openjdk.org
Thu Sep 14 15:57:45 UTC 2023


On Mon, 11 Sep 2023 23:42:37 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Lance Andersen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added additional tests, along with additional cleanup and refactoring
>
> test/jdk/java/util/zip/ZipFile/MissingZIP64EntriesTest.java line 52:
> 
>> 50:  * starting number is set to 0xFFFF or when we have a valid Zip64 Extra header
>> 51:  * size but missing the corresponding field.
>> 52:  * @run junit MissingZIP64EntriesTest
> 
> Is this comment accurate? I think we should check 3 cases when the header extra len == 0, len == 8 and len ==16, but still do not contain all required information.

Clarified the comment to make it a bit clearer and also added additional tests

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15650#discussion_r1326168515


More information about the core-libs-dev mailing list