RFR: 8315960: test/jdk/java/io/File/TempDirDoesNotExist.java leaves test files behind [v4]

[Roger Riggs]

On Fri, 15 Sep 2023 21:51:22 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Add a `finally` block to delete the created files.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8315960: Remove vestigial unused import

test/jdk/java/io/File/TempDirDoesNotExist.java line 53:

> 51:     private static final String USER_DIR = System.getProperty("user.home");
> 52: 
> 53:     public static void main(String... args) throws IOException {

Might be worth a comment that this is spawned to test combinations of parameters.

test/jdk/java/io/File/TempDirDoesNotExist.java line 55:

> 53:     public static void main(String... args) throws IOException {
> 54:         for (String arg : args) {
> 55:             if (arg.equals("io")) {

Maybe use switch on string instead of `if...else...`; a bit more compact.

test/jdk/java/io/File/TempDirDoesNotExist.java line 132:

> 130:                                           "io"
> 131:                                       });
> 132:         list.add(args);

You can use 

Stream.of( Arguments.of(..),
           Arguments.of(...),
           ...);

A bit more compact and without the explicit arglist.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15757#discussion_r1330656123
PR Review Comment: https://git.openjdk.org/jdk/pull/15757#discussion_r1330657821
PR Review Comment: https://git.openjdk.org/jdk/pull/15757#discussion_r1330663053