RFR: 8315960: test/jdk/java/io/File/TempDirDoesNotExist.java leaves test files behind [v4]
Brian Burkhalter
bpb at openjdk.org
Tue Sep 19 20:58:43 UTC 2023
On Tue, 19 Sep 2023 20:15:18 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8315960: Remove vestigial unused import
>
> test/jdk/java/io/File/TempDirDoesNotExist.java line 53:
>
>> 51: private static final String USER_DIR = System.getProperty("user.home");
>> 52:
>> 53: public static void main(String... args) throws IOException {
>
> Might be worth a comment that this is spawned to test combinations of parameters.
Comment added in cab8fa50a848f3c796bc81adcfd214aef0d054d3.
> test/jdk/java/io/File/TempDirDoesNotExist.java line 132:
>
>> 130: "io"
>> 131: });
>> 132: list.add(args);
>
> You can use
>
> Stream.of( Arguments.of(..),
> Arguments.of(...),
> ...);
>
> A bit more compact and without the explicit arglist.
So changed in cab8fa50a848f3c796bc81adcfd214aef0d054d3.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15757#discussion_r1330689736
PR Review Comment: https://git.openjdk.org/jdk/pull/15757#discussion_r1330689634
More information about the core-libs-dev
mailing list