RFR: 8316000: File.setExecutable silently fails if file does not exist [v7]

[Alan Bateman]

On Tue, 26 Sep 2023 18:03:54 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> On Windows, do not return `true` from the `java.io.File` methods `setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the file does not exist.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8316000: Modify spec and return verbiage

src/java.base/share/classes/java/io/File.java line 1630:

> 1628:      * method does nothing and returns the value of the {@code readable}
> 1629:      * parameter.
> 1630:      *

I think we are close to find the right wording for this. The return description looks fine. For the method description, I have two suggested changes:

1.  "If setting the read permission is supported" -> "If the platform supports settings a file's read permission".

2. "If the platform or underlying  file system does not support" -> "If the platform does not support". The reason for this is that the underlying file systems may or may support file permissions, an implementation can't distinguish those.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15673#discussion_r1338208315