RFR: 8316000: File.setExecutable silently fails if file does not exist [v7]

Brian Burkhalter bpb at openjdk.org
Wed Sep 27 16:19:10 UTC 2023


On Wed, 27 Sep 2023 08:03:38 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8316000: Modify spec and return verbiage
>
> src/java.base/share/classes/java/io/File.java line 1630:
> 
>> 1628:      * method does nothing and returns the value of the {@code readable}
>> 1629:      * parameter.
>> 1630:      *
> 
> I think we are really close to the final wording for this. The return description looks fine. For the method description, I have two suggested changes:
> 
> 1.  "If setting the read permission is supported" -> "If the platform supports settings a file's read permission".
> 
> 2. "If the platform or underlying  file system does not support" -> "If the platform does not support". The reason for this is that the underlying file systems may or may support file permissions, an implementation can't distinguish those.

Addressed in 5dabb216bcaf95bb3a3680fd76e5eb69f35f5fc1.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15673#discussion_r1338858437


More information about the core-libs-dev mailing list