RFR: 8317264: Pattern.Bound has `static` fields that should be `static final`. [v2]
Eamonn McManus
emcmanus at openjdk.org
Thu Sep 28 20:39:13 UTC 2023
> It looks to have been an oversight that `final` was omitted. The fields are never assigned after initialization. `final` leads to shorter bytecode.
Eamonn McManus has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
- Merge branch 'openjdk:master' into staticfinal
- In `Pattern.Bound`, make some constants `static final`.
It looks to have been an oversight that `final` was omitted. The fields are
never assigned after initialization. `final` leads to shorter bytecode.
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/15967/files
- new: https://git.openjdk.org/jdk/pull/15967/files/0a63d3f6..a10cf868
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=15967&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=15967&range=00-01
Stats: 255 lines in 11 files changed: 209 ins; 2 del; 44 mod
Patch: https://git.openjdk.org/jdk/pull/15967.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/15967/head:pull/15967
PR: https://git.openjdk.org/jdk/pull/15967
More information about the core-libs-dev
mailing list