RFR: 8317264: Pattern.Bound has `static` fields that should be `static final`. [v2]
Paul Sandoz
psandoz at openjdk.org
Thu Sep 28 21:55:24 UTC 2023
On Thu, 28 Sep 2023 20:39:13 GMT, Eamonn McManus <emcmanus at openjdk.org> wrote:
>> It looks to have been an oversight that `final` was omitted. The fields are never assigned after initialization. `final` leads to shorter bytecode.
>
> Eamonn McManus has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>
> - Merge branch 'openjdk:master' into staticfinal
> - In `Pattern.Bound`, make some constants `static final`.
>
> It looks to have been an oversight that `final` was omitted. The fields are
> never assigned after initialization. `final` leads to shorter bytecode.
Marked as reviewed by psandoz (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/15967#pullrequestreview-1649761096
More information about the core-libs-dev
mailing list