RFR: 8328995: launcher can't open jar files where the offset of the manifest is >4GB [v3]

[Liam Miller-Cushon]

On Fri, 29 Mar 2024 17:40:59 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:

>> Liam Miller-Cushon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make cendsk an unsigned short
>
> src/java.base/share/native/libjli/parse_manifest.c line 503:
> 
>> 501:                   || cenoff == ZIP64_MAGICVAL)
>> 502:                 && cenext > 0) {
>> 503:               Byte *base = p + CENHDR + CENNAM(p);
> 
> How about adding a comment describing the start of then extended fields calculation?
> 
> // The start of the extended fields = cen_header_start + cen_header_fixed_fix + file_name_length

Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18479#discussion_r1546911714