RFR: 8328995: launcher can't open jar files where the offset of the manifest is >4GB [v4]

Liam Miller-Cushon cushon at openjdk.org
Mon Apr 1 22:22:19 UTC 2024


On Fri, 29 Mar 2024 19:54:31 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:

>> I think it doesn't matter, because the validation below only uses `cenoff`. If `cenoff` fits in 32 bits, we don't need to read the zip64 extra info.
>
> Thanks for the explanation. Could you please add a comment with the info above the `if` statement?

I added a comment

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18479#discussion_r1546911662


More information about the core-libs-dev mailing list