RFR: 8328995: launcher can't open jar files where the offset of the manifest is >4GB [v5]

Jaikiran Pai jpai at openjdk.org
Thu Apr 4 09:45:10 UTC 2024


On Mon, 1 Apr 2024 22:22:19 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:

>> This change fixes a zip64 bug in the launcher that is prevent it from reading the manifest of jars where the 'relative offset of local header' field in the central directory entry is >4GB. As described in APPNOTE.TXT 4.5.3, the offset is too large to be stored in the central directory it is stored in a 'Zip64 Extended Information Extra Field'.
>
> Liam Miller-Cushon has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add some more comments

test/jdk/java/util/zip/Zip64Offsets.java line 1:

> 1: /*

Hello Liam, given that this PR is addressing an issue in the `java` launcher, I think this test should reside in `test/jdk/tools/launcher/` directory.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18479#discussion_r1551347422


More information about the core-libs-dev mailing list