RFR: 8328995: launcher can't open jar files where the offset of the manifest is >4GB [v5]

Liam Miller-Cushon cushon at openjdk.org
Thu Apr 4 16:57:40 UTC 2024


On Thu, 4 Apr 2024 09:42:48 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Liam Miller-Cushon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add some more comments
>
> test/jdk/java/util/zip/Zip64Offsets.java line 1:
> 
>> 1: /*
> 
> Hello Liam, given that this PR is addressing an issue in the `java` launcher, I think this test should reside in `test/jdk/tools/launcher/` directory.

I moved it to `test/jdk/tools/launcher/`, thanks!

(I modeled this after some other zip64 tests, which I now realize were originally added as tests for `java.util.zip`.)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18479#discussion_r1552080095


More information about the core-libs-dev mailing list