RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v24]

[Severin Gehwolf]

On Thu, 4 Apr 2024 13:00:33 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 100 commits:
>> 
>>  - Fix coment
>>  - Fix comment
>>  - Fix typo
>>  - Revert some now unneded build changes
>>  - Follow build tools naming convention
>>  - Update to new build-time approach with delta in lib
>>  - Make generation of fs_$module_files unconditional
>>  - Merge branch 'master' into jdk-8311302-jmodless-link
>>  - Fix copyright year
>>  - Move CreateLinkableRuntimePlugin to build folder
>>    
>>    Keep runtime link supporting classes in package
>>    jdk.tools.jlink.internal.runtimelink
>>  - ... and 90 more: https://git.openjdk.org/jdk/compare/6ae1cf12...ce04f42a
>
> make/Images.gmk line 208:
> 
>> 206:       WARN := Creating CDS$$($1_$2_DUMP_TYPE) archive for jdk image for $1, \
>> 207:       INFO := Using CDS flags for $1: $$($1_$2_CDS_DUMP_FLAGS), \
>> 208:       DEPS := $$(FINAL_JDK_JLINK), \
> 
> Does this actually interfere with the cds archive creation? I would assume they output to different files and they aren't even running `java` from the same image. If not, I would skip the whole `FINAL_JDK_JLINK` and just add `$(diff_runtime_jdk)` to `JDK_TARGETS`.

You are right. It no longer does (the old approach did, though). I'll clean it up.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1551898463