RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v24]

Severin Gehwolf sgehwolf at openjdk.org
Thu Apr 4 15:27:24 UTC 2024


On Thu, 4 Apr 2024 12:56:41 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 100 commits:
>> 
>>  - Fix coment
>>  - Fix comment
>>  - Fix typo
>>  - Revert some now unneded build changes
>>  - Follow build tools naming convention
>>  - Update to new build-time approach with delta in lib
>>  - Make generation of fs_$module_files unconditional
>>  - Merge branch 'master' into jdk-8311302-jmodless-link
>>  - Fix copyright year
>>  - Move CreateLinkableRuntimePlugin to build folder
>>    
>>    Keep runtime link supporting classes in package
>>    jdk.tools.jlink.internal.runtimelink
>>  - ... and 90 more: https://git.openjdk.org/jdk/compare/6ae1cf12...ce04f42a
>
> make/CompileToolsJdk.gmk line 50:
> 
>> 48:     EXCLUDES := \
>> 49:         build/tools/classlist \
>> 50:         build/tools/runtimeimagelinkdeltaproducer \
> 
> This directory name is comically long. I guess that's not really a problem, but perhaps "linkdelta" would be descriptive enough given that the class has the full name anyway?

FYI: This was trying to address a comment from @magicus https://github.com/openjdk/jdk/pull/14787#discussion_r1514894494 Happy to not follow that convention and/or rename the tool.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1551909878


More information about the core-libs-dev mailing list