RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v24]
Magnus Ihse Bursie
ihse at openjdk.org
Thu Apr 4 20:59:10 UTC 2024
On Thu, 4 Apr 2024 15:38:36 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> FYI: This was trying to address a comment from @magicus https://github.com/openjdk/jdk/pull/14787#discussion_r1514894494 Happy to not follow that convention and/or rename the tool.
>
> I was not aware of such a convention and I can't say I agree with it. It just seems redundant and unnecessary, but I suppose we should wait for Magnus to respond.
Just to clarify: I did not say the name needed to be long, just that many (if not all) tools has used the convention of using the package name `build.tools.<toolname>` and the class name `<ToolName>.java`.
I think the new name sounds 👍 .
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1552430689
More information about the core-libs-dev
mailing list