RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v24]

Erik Joelsson erikj at openjdk.org
Thu Apr 4 15:41:17 UTC 2024


On Thu, 4 Apr 2024 15:24:53 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> make/CompileToolsJdk.gmk line 50:
>> 
>>> 48:     EXCLUDES := \
>>> 49:         build/tools/classlist \
>>> 50:         build/tools/runtimeimagelinkdeltaproducer \
>> 
>> This directory name is comically long. I guess that's not really a problem, but perhaps "linkdelta" would be descriptive enough given that the class has the full name anyway?
>
> FYI: This was trying to address a comment from @magicus https://github.com/openjdk/jdk/pull/14787#discussion_r1514894494 Happy to not follow that convention and/or rename the tool.

I was not aware of such a convention and I can't say I agree with it. It just seems redundant and unnecessary, but I suppose we should wait for Magnus to respond.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1551940327


More information about the core-libs-dev mailing list