RFR: 8320575: generic type information lost on mandated parameters of record's compact constructors [v17]

Jan Lahoda jlahoda at openjdk.org
Mon Apr 29 12:05:18 UTC 2024


On Fri, 26 Apr 2024 23:54:17 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Reflection is not retrieving generic type information for mandated parameters. This is a known issue which has been explicitly stated in the API of some reflection methods. Fix for [JDK-8292275](https://bugs.openjdk.org/browse/JDK-8292275) made the parameters of compact constructors of record classes `mandated` as specified in the spec. But this implied that users that previous to this change could retrieve the generic type of parameters of compact constructors now they can't anymore. The proposed fix is to try to retrieve generic type information for mandated parameters if available plus changing the spec of the related reflection methods.
>> 
>> TIA
>
> Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:
> 
>   code refactoring

Makes sense to me. Moving the variable declarations to the else section may improve the code as suggest by @liach. Getting a review from somebody knowledgeable about the reflection might be good.

-------------

Marked as reviewed by jlahoda (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17070#pullrequestreview-2028320315


More information about the core-libs-dev mailing list