RFR: 8320575: generic type information lost on mandated parameters of record's compact constructors [v17]

Vicente Romero vromero at openjdk.org
Mon Apr 29 17:00:26 UTC 2024


On Sat, 27 Apr 2024 00:14:23 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   code refactoring
>
> src/java.base/share/classes/java/lang/reflect/Executable.java line 348:
> 
>> 346:                 final Type[] out = new Type[nonGenericParamTypes.length];
>> 347:                 final Parameter[] params = getParameters();
>> 348:                 if (getDeclaringClass().isRecord() && this instanceof Constructor) {
> 
> Sorry for late notice but we can move the 2 variable allocation to the else block, to speed up the record constructor path.

yep true, will do

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17070#discussion_r1583416245


More information about the core-libs-dev mailing list