RFR: 8335927: Revisit AnnotationConstantValueEntry and AnnotationValue.OfConstant [v2]

Chen Liang liach at openjdk.org
Fri Aug 2 13:19:49 UTC 2024


> 1. Add notes and docs about the difference between resolved constants and constant pool descriptors for annotation constants (e.g. `char` vs `IntegerEntry`)
> 2. Improved value specification to specify their tags.
> 3. Improved value factories to return their specific types instead of `OfConstant`
> 4. Improved value classes to return specific `PoolEntry` subtypes and specific live constant subtypes
> 5. Removed confusing and meaningless `ConstantPoolBuilder.annotationConstantValueEntry`

Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Remove generics, further improve docs
 - Merge branch 'master' of https://github.com/openjdk/jdk into fix/annotation-constant
 - 8335927: Revisit AnnotationConstantValueEntry and AnnotationValue.OfConstant

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20436/files
  - new: https://git.openjdk.org/jdk/pull/20436/files/611a9505..b212a3ec

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20436&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20436&range=00-01

  Stats: 234 lines in 19 files changed: 111 ins; 17 del; 106 mod
  Patch: https://git.openjdk.org/jdk/pull/20436.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20436/head:pull/20436

PR: https://git.openjdk.org/jdk/pull/20436


More information about the core-libs-dev mailing list