RFR: 8335927: Revisit AnnotationConstantValueEntry and AnnotationValue.OfConstant [v3]

Chen Liang liach at openjdk.org
Fri Aug 2 14:19:52 UTC 2024


> 1. Add notes and docs about the difference between resolved constants and constant pool descriptors for annotation constants (e.g. `char` vs `IntegerEntry`)
> 2. Improved value specification to specify their tags.
> 3. Improved value factories to return their specific types instead of `OfConstant`
> 4. Improved value classes to return specific `PoolEntry` subtypes and specific live constant subtypes
> 5. Removed confusing and meaningless `ConstantPoolBuilder.annotationConstantValueEntry`

Chen Liang has updated the pull request incrementally with two additional commits since the last revision:

 - poolEntry back to constant
 - OfInteger/Character -> OfInt/Char

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20436/files
  - new: https://git.openjdk.org/jdk/pull/20436/files/b212a3ec..d2f56527

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20436&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20436&range=01-02

  Stats: 67 lines in 10 files changed: 1 ins; 0 del; 66 mod
  Patch: https://git.openjdk.org/jdk/pull/20436.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20436/head:pull/20436

PR: https://git.openjdk.org/jdk/pull/20436


More information about the core-libs-dev mailing list