RFR: 8335927: Revisit AnnotationConstantValueEntry and AnnotationValue.OfConstant [v5]

Chen Liang liach at openjdk.org
Fri Aug 2 16:31:48 UTC 2024


> 1. Add notes and docs about the difference between resolved constants and constant pool descriptors for annotation constants (e.g. `char` vs `IntegerEntry`)
> 2. Improved value specification to specify their tags.
> 3. Improved value factories to return their specific types instead of `OfConstant`
> 4. Improved value classes to return specific `PoolEntry` subtypes and specific live constant subtypes
> 5. Removed confusing and meaningless `ConstantPoolBuilder.annotationConstantValueEntry`

Chen Liang has updated the pull request incrementally with one additional commit since the last revision:

  Fix another failing test

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20436/files
  - new: https://git.openjdk.org/jdk/pull/20436/files/d3390fd6..fb6b2f99

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20436&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20436&range=03-04

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/20436.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20436/head:pull/20436

PR: https://git.openjdk.org/jdk/pull/20436


More information about the core-libs-dev mailing list