RFR: 8335927: Revisit AnnotationConstantValueEntry and AnnotationValue.OfConstant [v5]

[Adam Sotona]

On Fri, 2 Aug 2024 16:31:48 GMT, Chen Liang <liach at openjdk.org> wrote:

>> 1. Add notes and docs about the difference between resolved constants and constant pool descriptors for annotation constants (e.g. `char` vs `IntegerEntry`)
>> 2. Improved value specification to specify their tags.
>> 3. Improved value factories to return their specific types instead of `OfConstant`
>> 4. Improved value classes to return specific `PoolEntry` subtypes and specific live constant subtypes
>> 5. Removed confusing and meaningless `ConstantPoolBuilder.annotationConstantValueEntry`
>
> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix another failing test

Looks good to me, thanks.

-------------

Marked as reviewed by asotona (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20436#pullrequestreview-2233337319