RFR: 8336462: ConcurrentSkipListSet Javadoc incorrectly warns about size method complexity [v2]

Jaikiran Pai jpai at openjdk.org
Mon Aug 5 10:26:32 UTC 2024


On Mon, 5 Aug 2024 09:52:54 GMT, Viktor Klang <vklang at openjdk.org> wrote:

>> Viktor Klang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adding paragraph to ConcurrentSkipListSet::set
>
> src/java.base/share/classes/java/util/concurrent/ConcurrentSkipListSet.java line 192:
> 
>> 190:      * returns {@code Integer.MAX_VALUE}.
>> 191:      *
>> 192:      * <p>It is possible for the size to change during execution of this method,
> 
> @jaikiran Realized the paragraph fell away so I re-added it. Reapproval needed?

Hello Viktor, the new review process in the JDK project marks the previous review as stale if a change is done after the approval. Re-review is mandated in such cases. I've now approved the latest change which looks good to me.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20388#discussion_r1703897877


More information about the core-libs-dev mailing list