RFR: 8336462: ConcurrentSkipListSet Javadoc incorrectly warns about size method complexity [v2]

Viktor Klang vklang at openjdk.org
Mon Aug 5 10:56:38 UTC 2024


On Mon, 5 Aug 2024 10:23:27 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> src/java.base/share/classes/java/util/concurrent/ConcurrentSkipListSet.java line 192:
>> 
>>> 190:      * returns {@code Integer.MAX_VALUE}.
>>> 191:      *
>>> 192:      * <p>It is possible for the size to change during execution of this method,
>> 
>> @jaikiran Realized the paragraph fell away so I re-added it. Reapproval needed?
>
> Hello Viktor, the new review process in the JDK project marks the previous review as stale if a change is done after the approval. Re-review is mandated in such cases. I've now approved the latest change which looks good to me.

Thanks @jaikiran 👍

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20388#discussion_r1703932924


More information about the core-libs-dev mailing list