RFR: 8315884: New Object to ObjectMonitor mapping [v15]

Axel Boldt-Christmas aboldtch at openjdk.org
Wed Aug 14 06:06:57 UTC 2024


On Tue, 13 Aug 2024 16:34:17 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Axel Boldt-Christmas has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Remove the last OMWorld references
>>  - Rename omworldtable_work to object_monitor_table_work
>
> src/hotspot/share/runtime/lightweightSynchronizer.hpp line 41:
> 
>> 39: 
>> 40:   static ObjectMonitor* add_monitor(JavaThread* current, ObjectMonitor* monitor, oop obj);
>> 41:   static bool remove_monitor(Thread* current, oop obj, ObjectMonitor* monitor);
> 
> Hmmm... `add_monitor` has `monitor` and then `obj` params.
> `remove_monitor` has `obj` and then `monitor` params. Why
> not use the same order?

Yeah, why not? :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20067#discussion_r1716353596


More information about the core-libs-dev mailing list