RFR: 8315884: New Object to ObjectMonitor mapping [v15]

Axel Boldt-Christmas aboldtch at openjdk.org
Wed Aug 14 06:35:01 UTC 2024


On Tue, 13 Aug 2024 17:05:38 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Axel Boldt-Christmas has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Remove the last OMWorld references
>>  - Rename omworldtable_work to object_monitor_table_work
>
> src/hotspot/share/runtime/lightweightSynchronizer.cpp line 126:
> 
>> 124: 
>> 125:   static void dec_items_count() {
>> 126:     Atomic::inc(&_items_count);
> 
> Shouldn't this be `Atomic::dec`?

Yes it should be. Surprised I never saw this. (Even though that using the service thread to grow was the very last thing changed before the PR, the resizing was handled differently before, by the deflator thread.)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20067#discussion_r1716377509


More information about the core-libs-dev mailing list