RFR: 8336895: BufferedReader doesn't read full \r\n line ending when it doesn't fit in buffer [v3]
Jaikiran Pai
jpai at openjdk.org
Wed Aug 28 14:57:21 UTC 2024
On Fri, 26 Jul 2024 22:32:40 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> Add some verbiage stating that two buffered readers or input streams should not be used to read from the same reader or input stream, respectively.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>
> 8336895: Modified verbiage per reviewer comment
src/java.base/share/classes/java/io/BufferedInputStream.java line 54:
> 52: *
> 53: * <p> More than one instance of {@code BufferedInputStream} should not be
> 54: * used with the same underlying {@code InputStream} instance. Doing
Nit - there's one extra space here before the `Doing`. Same in the other classes as well.
src/java.base/share/classes/java/io/BufferedReader.java line 62:
> 60: * replacing each DataInputStream with an appropriate BufferedReader.
> 61: *
> 62: * <p> More than one instance of BufferedReader should not be used with the
Nit - In the `BufferedInputStream` and the `BufferedOutputStream` we use `{@code ...}` to refer to these classes. Perhaps we should do the same here for `BufferedReader` and `Reader`? Same comment in the `BufferedWriter` class update.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20320#discussion_r1734835883
PR Review Comment: https://git.openjdk.org/jdk/pull/20320#discussion_r1734842931
More information about the core-libs-dev
mailing list