RFR: 8336895: BufferedReader doesn't read full \r\n line ending when it doesn't fit in buffer [v3]

Brian Burkhalter bpb at openjdk.org
Wed Aug 28 16:40:23 UTC 2024


On Wed, 28 Aug 2024 14:53:37 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8336895: Modified verbiage per reviewer comment
>
> src/java.base/share/classes/java/io/BufferedReader.java line 62:
> 
>> 60:  * replacing each DataInputStream with an appropriate BufferedReader.
>> 61:  *
>> 62:  * <p> More than one instance of BufferedReader should not be used with the
> 
> Nit - In the `BufferedInputStream` and the `BufferedOutputStream` we use `{@code ...}` to refer to these classes. Perhaps we should do the same here for `BufferedReader` and `Reader`? Same comment in the `BufferedWriter`  class update.

Yes, I saw that but did not want to change it in the initial pass(es) as it's too much noise. If things are otherwise quiescent, then I can change it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20320#discussion_r1734992217


More information about the core-libs-dev mailing list