RFR: 8339154: Cleanups and JUnit conversion of test/jdk/java/util/zip/Available.java [v2]

Eirik Bjørsnøs eirbjo at openjdk.org
Thu Aug 29 16:50:56 UTC 2024


> Please review this test-only PR which addresses several issues with the `test/jdk/java/util/zip/Available.java` test:
> 
> * The test is converted to JUnit 5
> * The test now creates its own test vector programmatically instead of relying on a binary `input.jar` test vector 
> * Coverage is added for calling `available()` after calling `ZipInputStream.closeEntry`, as expected by the API specification for `ZipInputStream.available`
> * Coverage is added for calling `available()` on a closed `ZipInputStream`
> * Coverage is added for the unspecified, but long-standing behavior of `ZipFileInputStream.available()` (The InputStream returned for `STORED` entries)
> 
> Additionally, the test is split into multiple methods, adding javadoc comments for each of them.

Eirik Bjørsnøs has updated the pull request incrementally with one additional commit since the last revision:

  Collapse the ZipFile-related tests into a single, parameterized method

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20744/files
  - new: https://git.openjdk.org/jdk/pull/20744/files/39e61bac..8ae9e0d4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20744&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20744&range=00-01

  Stats: 58 lines in 1 file changed: 7 ins; 34 del; 17 mod
  Patch: https://git.openjdk.org/jdk/pull/20744.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20744/head:pull/20744

PR: https://git.openjdk.org/jdk/pull/20744


More information about the core-libs-dev mailing list