RFR: 8339154: Cleanups and JUnit conversion of test/jdk/java/util/zip/Available.java [v2]

Lance Andersen lancea at openjdk.org
Thu Aug 29 16:58:18 UTC 2024


On Thu, 29 Aug 2024 16:50:56 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

>> Please review this test-only PR which addresses several issues with the `test/jdk/java/util/zip/Available.java` test:
>> 
>> * The test is converted to JUnit 5
>> * The test now creates its own test vector programmatically instead of relying on a binary `input.jar` test vector 
>> * Coverage is added for calling `available()` after calling `ZipInputStream.closeEntry`, as expected by the API specification for `ZipInputStream.available`
>> * Coverage is added for calling `available()` on a closed `ZipInputStream`
>> * Coverage is added for the unspecified, but long-standing behavior of `ZipFileInputStream.available()` (The InputStream returned for `STORED` entries)
>> 
>> Additionally, the test is split into multiple methods, adding javadoc comments for each of them.
>
> Eirik Bjørsnøs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Collapse the ZipFile-related tests into a single, parameterized method

Thank you for the additional tweaks/improvements.


Test looks much better

-------------

Marked as reviewed by lancea (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20744#pullrequestreview-2269522988


More information about the core-libs-dev mailing list