RFR: 8339154: Cleanups and JUnit conversion of test/jdk/java/util/zip/Available.java [v2]

[Eirik Bjørsnøs]

On Thu, 29 Aug 2024 16:50:56 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

>> Please review this test-only PR which addresses several issues with the `test/jdk/java/util/zip/Available.java` test:
>> 
>> * The test is converted to JUnit 5
>> * The test now creates its own test vector programmatically instead of relying on a binary `input.jar` test vector 
>> * Coverage is added for calling `available()` after calling `ZipInputStream.closeEntry`, as expected by the API specification for `ZipInputStream.available`
>> * Coverage is added for calling `available()` on a closed `ZipInputStream`
>> * Coverage is added for the unspecified, but long-standing behavior of `ZipFileInputStream.available()` (The InputStream returned for `STORED` entries)
>> 
>> Additionally, the test is split into multiple methods, adding javadoc comments for each of them.
>
> Eirik Bjørsnøs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Collapse the ZipFile-related tests into a single, parameterized method

Turns out that naming a ZipEntry "stored.txt" does not actually make it stored! 🤦 

@LanceAndersen I'll need a re-review for the following line in `setup`:

`stored.setMethod(ZipEntry.STORED);`

I have verified using the debugger that each invocation now sees the expected ZipFile InputStream implementation.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20744#issuecomment-2318393509