RFR: 8336043: Add quality of implementation discussion to Object.{equals, toString, hashCode} [v5]

[Chen Liang]

On Wed, 24 Jul 2024 05:33:29 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> I would hope to spend as little space on this as possible, perhaps "This method should avoid throwing or propagating any exceptions unless it legitimately _cannot_ adhere to this contract."
>> (or shorter)
>
>> I would hope to spend as little space on this as possible, perhaps "This method should avoid throwing or propagating any exceptions unless it legitimately _cannot_ adhere to this contract." (or shorter)
> 
> Pushed a version using that worked, but I expect discussion will continue.

Since you mentioned "normally" from the JLS, can we something like:

> during typical operation these methods should complete normally, that is, they do not throw any exception, except unrecoverable ones outside of the method's direct control, like {@link VirtualMachineError}.

(The term "exception" seems to refer to general Throwable in JLS)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20128#discussion_r1867072896