RFR: 8336043: Add quality of implementation discussion to Object.{equals, toString, hashCode} [v5]
Chen Liang
liach at openjdk.org
Tue Dec 3 05:27:41 UTC 2024
On Wed, 7 Aug 2024 00:02:46 GMT, Joe Darcy <darcy at openjdk.org> wrote:
>> First pass at adding some quality of implementation discussions around the overridable methods of Object.
>
> Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>
> - Fix typo found in code review.
> - Merge branch 'master' into JDK-8336043
> - Merge branch 'master' into JDK-8336043
> - Respond to review feedback.
> - Merge branch 'master' into JDK-8336043
> - Appease jcheck.
> - JDK-8336043: Add quality of implementation discussion to Object.{equals, toString, hashCode}
src/java.base/share/classes/java/lang/Object.java line 118:
> 116: *
> 117: * <p>This method should avoid throwing or propagating any
> 118: * exceptions unless it legitimately <em>cannot</em> adhere to its
should we use terms like "recoverable exceptions" to distinguish things like exceptions from Integer.parseInt?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20128#discussion_r1867073408
More information about the core-libs-dev
mailing list