RFR: 8342035: jlink plugins for setting java.vendor, java.vm.vendor and java.vendor.url [v4]
Mandy Chung
mchung at openjdk.org
Wed Dec 4 18:06:44 UTC 2024
On Wed, 4 Dec 2024 07:31:24 GMT, Henry Jen <henryjen at openjdk.org> wrote:
>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor and java.vendor.url.
>>
>> The jlink plugin will change the value in java.lang.VersionProps, which will set those property values. The `java.vm.vendor` was initialized by VM with value set at build time, and then later be replaced with value from VersionProps.
>>
>> To keep current behavior, we treat 'N/A' value as no-op to mimic current build behavior. Perhaps we don't really need this, as proper value should be set with `branding.conf` in official build.
>
> Henry Jen has updated the pull request incrementally with one additional commit since the last revision:
>
> Clean up adapting review comments
make/autoconf/spec.gmk.template line 276:
> 274:
> 275: ifneq ($(COMPANY_NAME), )
> 276: VERSION_CFLAGS += -DVENDOR='"$(COMPANY_NAME)"'
With this change, it will also fix the value of `java.vm.vendor` system property to "N/A" instead of "Oracle Corporation" hardcoded in the source. The CSR can mention this change.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21964#discussion_r1870038850
More information about the core-libs-dev
mailing list