RFR: 8342035: jlink plugins for setting java.vendor, java.vm.vendor and java.vendor.url [v4]
Henry Jen
henryjen at openjdk.org
Wed Dec 4 18:26:41 UTC 2024
On Wed, 4 Dec 2024 18:03:42 GMT, Mandy Chung <mchung at openjdk.org> wrote:
>> Henry Jen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Clean up adapting review comments
>
> make/autoconf/spec.gmk.template line 276:
>
>> 274:
>> 275: ifneq ($(COMPANY_NAME), )
>> 276: VERSION_CFLAGS += -DVENDOR='"$(COMPANY_NAME)"'
>
> With this change, it will also fix the value of `java.vm.vendor` system property to "N/A" instead of "Oracle Corporation" hardcoded in the source. The CSR can mention this change.
That's for OpenJDK build with default branding.conf though. Build with proper branding.conf setup or configured using --with-vendor-name won't be affected.
In fact, IIUC, `--with-vendor-name='N/A'` won't work either.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21964#discussion_r1870067820
More information about the core-libs-dev
mailing list